carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 265304.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ABataev added a comment.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli updated this revision to Diff 52416.
carlo.bertolli added a comment.
[OPENMP] Even though this patch was already accepted in its previous form,
comments on depending patch http://reviews.llvm.org/D18286
(http://reviews.llvm.org/D18286) revealed that a new approach for this patch
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:32-59
@@ +31,30 @@
+ /// \param ThreadLimit An integer expression of threads.
+ virtual void emitNumTeamsClause(CodeGenFu
carlo.bertolli added a comment.
I can actually add a regression test that checks that the compiler does not
break when using a global in a teams region, even without declare target, if
that is what is required here.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
_
carlo.bertolli added a comment.
Support for global variables in a target region requires the global to be
placed in a pragma declare target region. Pragma declare target region is not
currently available in Clang (no parsing, sema, or codegen). I will add a check
for this in the regression test
ABataev added a comment.
Add tests with captured globals to check that this problem is resolved
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
carlo.bertolli updated this revision to Diff 50187.
carlo.bertolli added a comment.
[OPENMP] This new version of the patch uses the inlining machinery of
CGOpenMPRuntime.cpp instead of just dumping the teams body statement using
EmitStmt.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Addressed comment in new version of diff.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:51-52
@@ +50,4 @@
+
+ // just emit the statements in the teams region, no need for outlining
+ CGF.EmitStmt(cast(D.getAssociatedStmt())->getCapturedStmt());
+}
This will cause a cras
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
Herald added a subscriber: jholewinski.
This patch imp
11 matches
Mail list logo
