Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

2016-03-15 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263567: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D17947?vs=50055&id=50755#toc Repository: rL LLVM http://rev

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

2016-03-15 Thread Chris Bieneman via cfe-commits
beanz added a comment. Ping. http://reviews.llvm.org/D17947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

2016-03-08 Thread Chris Bieneman via cfe-commits
beanz updated this revision to Diff 50055. beanz added a comment. Updates based on Anna's polite and restrained feedback that didn't include the appropriate comment "Why don't you fix your TODO?" (I did fix it this time). http://reviews.llvm.org/D17947 Files: lib/Driver/ToolChains.cpp test

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

2016-03-07 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. You should be able to use the switch like in Darwin::getOSLibraryNameSuffix(), right? That's much better. http://reviews.llvm.org/D17947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

2016-03-07 Thread Chris Bieneman via cfe-commits
beanz created this revision. beanz added reviewers: zaks.anna, bogner. beanz added a subscriber: cfe-commits. isTarget*() calls are order-dependent. This is because iOS Sim *is* iOS. This means checks for the simulator version of the platform must always be ahead of checks for the embedded platf