Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-15 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263552: [OpenMP] Base support for target directive codegen on NVPTX device. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D17877?vs=50143&id=50737#toc Repository: rL LLVM ht

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Arpith Jacob via cfe-commits
arpith-jacob marked an inline comment as done. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentNa

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName,

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Arpith Jacob via cfe-commits
arpith-jacob marked 9 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentNa

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-09 Thread Arpith Jacob via cfe-commits
arpith-jacob updated this revision to Diff 50143. arpith-jacob marked 2 inline comments as done. arpith-jacob added a comment. Stylistic changes to address feedback. http://reviews.llvm.org/D17877 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRun

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-08 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName, Missed 'virt

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-04 Thread Arpith Jacob via cfe-commits
arpith-jacob marked 15 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:348 @@ +347,2 @@ + initializeEnvironment(); +} This function will also handle global variables from the 'declare target' construct in the future. void CGOpenMPRunti

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-04 Thread Arpith Jacob via cfe-commits
arpith-jacob updated this revision to Diff 49851. arpith-jacob added a comment. Addressed feedback; see inline comments for details. http://reviews.llvm.org/D17877 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/CodeGen/CGOpe

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-03 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3790 @@ -3923,3 +3789,3 @@ // where DD_ is an ID unique to the file (device and file IDs), PP is the - // mangled name of the function that encloses the target region and BB is the + // mangled nam

[PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-03 Thread Arpith Jacob via cfe-commits
arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, hfinkel. arpith-jacob added subscribers: cfe-commits, carlo.bertolli, sfantao, kkwli0, caomhin, fraggamuffin. Herald added a subscriber: jholewinski. This patch adds base support for codegen of the target directive on the