manmanren added a comment.
Uploading a new patch addressing Aaron's comments:
1> Add an optional string argument for fix-it, instead of the original proposal
of named argument `Replacement = "xxx"`
This actually simplifies the patch a lot
2> Add testing cases to make sure we don't accept a fix-it
bob.wilson added a comment.
> I do like the explicit nature of this approach, but I'm worried about it
> being too novel. For instance, would this compel GCC to implement a similar
> parsing feature since they also support the deprecated attribute, that sort
> of thing. Also, it feels like a bi
aaron.ballman added a comment.
In http://reviews.llvm.org/D17865#370912, @manmanren wrote:
> Hi Aaron,
>
> Thanks for the review!
>
> > I like the idea of a potential fixit being provided by the attribute, but I
> > do not agree with the way the feature is surfaced in this patch.
>
> >
>
> > Fo
manmanren added a comment.
Hi Aaron,
Thanks for the review!
> I like the idea of a potential fixit being provided by the attribute, but I
> do not agree with the way the feature is surfaced in this patch.
>
> For the GNU-style attribute, the named argument functionality is sufficiently
> no
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
I like the idea of a potential fixit being provided by the attribute, but I do
not agree with the way the feature is surfaced in this patch.
For the GNU-style attribute,
manmanren added a comment.
Ping
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren created this revision.
manmanren added reviewers: dexonsmith, rjmccall.
manmanren added a subscriber: cfe-commits.
This can be used to display Fix-Its.
We only add this to GNU attributes. Since it now has two optional arguments,
and the common parsing does not handle "replacement = ", w
