aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
One small documentation nit, but I'm fine with you fixing it then committing
(no need for another round of review). Thanks!
Comment at: include/clang/Basic/Attr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263652: Add an optional string argument to DeprecatedAttr
for Fix-It. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D17865?vs=50682&id=50844#toc
Repository:
rL LLVM
http://rev
manmanren updated this revision to Diff 50682.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Lex/PPMacroExpansion.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr-deprecated-replacement-error.cpp
test/SemaCXX/attr-deprecated-repla
aaron.ballman added a comment.
In http://reviews.llvm.org/D17865#374939, @manmanren wrote:
> In http://reviews.llvm.org/D17865#374659, @aaron.ballman wrote:
>
> > Aside from the missing attribute documentation, looks good to me.
>
>
> Hi Aaron,
>
> Which document are you referring to? "include/cl
manmanren added a comment.
In http://reviews.llvm.org/D17865#374659, @aaron.ballman wrote:
> Aside from the missing attribute documentation, looks good to me.
Hi Aaron,
Which document are you referring to? "include/clang/Basic/AttrDocs.td"?
We don't have a section for DeprecatedAttr, should I
aaron.ballman added a comment.
Aside from the missing attribute documentation, looks good to me.
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren marked 3 inline comments as done.
manmanren added a comment.
Upload patch to address review comments.
Thanks,
Manman
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
manmanren updated this revision to Diff 50502.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr-deprecated-replacement-error.cpp
test/SemaCXX/attr-deprecated-replacement-fixit.cpp
test/SemaCXX/cx
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:726
@@ +725,3 @@
+ let Args = [StringArgument<"Message", 1>,
+ // An optional string argument that enables us to provide a Fix-It.
+ StringArgument<"Replacement", 1>];
The
manmanren added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:1234
@@ +1233,3 @@
+if ((Spelling == "deprecated" || Spelling == "gnu::deprecated") &&
+Variety != "GNU" && index == 1)
+ continue;
This does not look pre
manmanren retitled this revision from "Add replacement = "xxx" to
DeprecatedAttr." to "Add an optional string argument to DeprecatedAttr for
Fix-It.".
manmanren updated this revision to Diff 50374.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cp
11 matches
Mail list logo
