Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-03 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262595: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D17807?vs=49615&id=49718#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-02 Thread David Blaikie via cfe-commits
On Wed, Mar 2, 2016 at 10:36 AM, Benjamin Kramer wrote: > In theory yes, in practice that needs a bit of build system tweaking > to either build clang-tidy into clang or as a shared library. Then it > can be used like any regular Clang plugin. > I haven't looked at this patch in detail - soundds

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-02 Thread Benjamin Kramer via cfe-commits
In theory yes, in practice that needs a bit of build system tweaking to either build clang-tidy into clang or as a shared library. Then it can be used like any regular Clang plugin. It will also slow down clang significantly, but I consider that a bug ;) On Wed, Mar 2, 2016 at 6:21 PM, David Blai

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-02 Thread David Blaikie via cfe-commits
Would this also be usable as a way to run clang-tidy checks as part of normal compilation? (some things in clang-tidy aren't there because the FP is too high to be a hard error on old codebases (but might be viable once a codebase is able to be cleaned up (like several have been with LLVM)) or beca

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-02 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. For now I don't see a better path forward. http://reviews.llvm.org/D17807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

2016-03-02 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This doesn't really do much at the moment. You can load it via libclang and set the -checks via an extra command line argument as illustrated in the test case. Support for other options (inclu