Re: [PATCH] D17799: Serialize `#pragma comment`.

2016-03-02 Thread Nico Weber via cfe-commits
thakis added a comment. Also landed a very similar change for the very similar detect_mismatch pragma in r262506. (The other missing serialized pragmas will use a different approach.) http://reviews.llvm.org/D17799 ___ cfe-commits mailing list cfe

Re: [PATCH] D17799: Serialize `#pragma comment`.

2016-03-02 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. r262493, thanks! http://reviews.llvm.org/D17799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17799: Serialize `#pragma comment`.

2016-03-02 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D17799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17799: Serialize `#pragma comment`.

2016-03-02 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: rnk. thakis added a subscriber: cfe-commits. `#pragma comment` was handled by Sema calling a function on ASTConsumer, and CodeGen then implementing this function and writing things to its output. Instead, introduce a PragmaCommentDecl AST no