rsmith added a comment.
It seems to me that the bug is that we're producing an invalid source location,
not how we handle that downstream. Typo correction should be able to preserve
the source location of whatever expression it was correcting.
Comment at: lib/Sema/SemaExpr.cpp
hokein added a comment.
friendly ping @rsmith.
http://reviews.llvm.org/D17762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer added a comment.
I'm still not sure if this is the right way to fix it. Maybe @rsmith has an
opinion?
http://reviews.llvm.org/D17762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hokein updated this revision to Diff 49939.
hokein added a comment.
Update.
http://reviews.llvm.org/D17762
Files:
lib/Sema/SemaExpr.cpp
test/Sema/PR25668.cpp
Index: test/Sema/PR25668.cpp
===
--- /dev/null
+++ test/Sema/PR25668
hokein added a comment.
In http://reviews.llvm.org/D17762#367182, @bkramer wrote:
> This doesn't look right to me. Aborting tree transform on a bad source
> location seems just wrong. Where is the invalid source location coming from?
> Also the backtrace seems related to typo correction, maybe
bkramer added a comment.
This doesn't look right to me. Aborting tree transform on a bad source location
seems just wrong. Where is the invalid source location coming from? Also the
backtrace seems related to typo correction, maybe the bug is there?
Repository:
rL LLVM
http://reviews.llvm.o
hokein added a comment.
friendly ping.
Repository:
rL LLVM
http://reviews.llvm.org/D17762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
