This revision was automatically updated to reflect the committed changes.
Closed by commit rL262379: [MSVC Compat] Correctly handle finallys nested
within finallys (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17752?vs=49522&id=49525#toc
Repository:
rL LLVM
http:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer updated this revision to Diff 49522.
majnemer added a comment.
- Address Reid's review comments
http://reviews.llvm.org/D17752
Files:
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/exceptions-seh-finally.c
Index: test/Cod
rnk added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1680-1682
@@ -1679,4 +1679,5 @@
StartFunction(GlobalDecl(), RetTy, Fn, FnInfo, Args,
OutlinedStmt->getLocStart(), OutlinedStmt->getLocStart());
+ CurCodeDecl = ParentCGF.CurCodeDecl;
--
majnemer created this revision.
majnemer added reviewers: rnk, andrew.w.kaylor.
majnemer added a subscriber: cfe-commits.
We'd lose track of the parent CodeGenFunction, leading us to get
confused with regard to which function a nested finally belonged to.
http://reviews.llvm.org/D17752
Files:
