EricWF added a comment.
OK. Thanks for the update. Sorry we couldn't land this.
http://reviews.llvm.org/D17734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda abandoned this revision.
hintonda added a comment.
If *_COMPILER_ARG1 is set, then it shall be the compiler, and the value for
CMAKE__COMPILER may be ccache, but could also be something else, e.g.,
distcc, etc. Therefore, I don't see a clean way to check it.
However, newer versions of
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I appreciate the patch, handling 'ccache' is a good thing to have. I'll look
at this again once the inline comment is addressed.
Comment at: CMakeLists.txt:225
@@
hintonda created this revision.
hintonda added a reviewer: mclow.lists.
hintonda added a subscriber: cfe-commits.
If you use ccache to build libcxx by setting CXX="ccache
clang++", check-libcxx will fail since LIBCXX_COMPILER will be set to
"ccache".
We can't just include CMAKE_CXX_COMPILER_ARG1
