Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Manuel Klimek via cfe-commits
klimek closed this revision. klimek added a comment. Submitted as r262232 http://reviews.llvm.org/D17704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 49359. ioeric marked an inline comment as done. ioeric added a comment. - return Replacements() instead of the empty Replaces. http://reviews.llvm.org/D17704 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Too

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 49355. ioeric marked 8 inline comments as done. ioeric added a comment. - removed applyAllReplacementsAndFormat with Rewritter interface. reduced the column limit in test case; some formatting. http://reviews.llvm.org/D17704 Files: include/clang/Tooling/C

[PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Merge branch 'master' of http://llvm.org/git/clang http://reviews.llvm.org/D17704 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replace

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: lib/Tooling/Core/Replacement.cpp:290 @@ +289,3 @@ + const format::FormatStyle &Style) { + if (Replaces.empty()) return

Re: [PATCH] D17704: Added interfaces for code-formatting while applying replacements.

2016-02-29 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:227-232 @@ -222,1 +226,8 @@ +/// \brief Applies all replacements in \p Replaces to \p Code. +/// +/// This completely ignores the path stored in each replacement. If one or more +/// replacements