This revision was automatically updated to reflect the committed changes.
Closed by commit rL262239: [PGO] clang cc1 option change to enable IR level
instrumentation (authored by xur).
Changed prior to commit:
http://reviews.llvm.org/D17622?vs=49243&id=49394#toc
Repository:
rL LLVM
http://r
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM.
http://reviews.llvm.org/D17622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
xur updated this revision to Diff 49243.
xur added a comment.
Sean, Thanks for the review and suggestions.
Here is the patch that only adds -fprofile-instrument=llvm.
I'll have another patch using your suggestion on cc1 options for profile use
compilation.
http://reviews.llvm.org/D17622
File
silvas added a comment.
Thanks for splitting this out.
I think the `-fprofile-instrument=llvm` is straightforward and uncontroversial.
Let's focus this review on that and split the others into a separate review.
But a quick preview of my thoughs about `-fprofile-instrument={llvm,clang}-use`:
I
xur created this revision.
xur added reviewers: davidxl, silvas, justinruggles.
xur added subscribers: cfe-commits, xur, mcrosier, davidxl, slingn.
This patch expands cc1 option -fprofile-instrument= with three new values:
(1) -fprofile-instrument=llvm
This enables IR PGO instrumentation.
(2) -fpr
