Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261868: [clang-tidy] update links to Google Code Style in docs (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D17602?vs=49048&id=49052#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaratio

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaration

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Thank you very much, @hokein! http://reviews.llvm.org/D17602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. LGTM. I will commit the patch for you @omtcyf0. http://reviews.llvm.org/D17602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaratio

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Hajian, if you have no concerns, could you commit the patch? Thanks! http://reviews.llvm.org/D17602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! http://reviews.llvm.org/D17602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaration

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,2 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions All parameters should be named, with identical names in the declaratio

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 49048. omtcyf0 added a comment. Removed the breakline. http://reviews.llvm.org/D17602 Files: clang-tidy/google/AvoidCStyleCastsCheck.h clang-tidy/google/ExplicitConstructorCheck.h clang-tidy/google/OverloadedUnaryAndCheck.h clang-tidy/google/Unnamed

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,1 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_ +Definitions omtcyf0 wrote: > hokein wrote: > > This should be in

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,1 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_ +Definitions hokein wrote: > This should be in one line? It is in

Re: [PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13 @@ -13,1 +12,3 @@ +https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_ +Definitions This should be in one line? http://reviews.llvm.org

[PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

2016-02-25 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: cfe-commits, alexfh. Because of the recent Google Code shutdown links to the Google Code Style up there are no longer relevant. http://reviews.llvm.org/D17602 Files: clang-tidy/google/AvoidCStyleCastsCheck.h clang-tidy/google/ExplicitC