Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

2016-02-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261803: Fix assertion failure on MaybeODRUseExprs. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D17576?vs=48963&id=48986#toc Repository: rL LLVM http://reviews.llvm.org/D1757

Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

2016-02-24 Thread Richard Smith via cfe-commits
rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114 @@ -2113,1 +2113,3 @@ +EnterExpressionEvaluationContext ConstantEvaluated(SemaRef, +

Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

2016-02-24 Thread Faisal Vali via cfe-commits
faisalv added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114 @@ -2113,1 +2113,3 @@ +EnterExpressionEvaluationContext ConstantEvaluated(SemaRef, + Sema::ConstantEvaluated); ExprResult Value

[PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

2016-02-24 Thread Manman Ren via cfe-commits
manmanren created this revision. manmanren added reviewers: rsmith, EricWF, faisalv. manmanren added a subscriber: cfe-commits. In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument, we should create a ConstantEvaluated ExpressionEvaluationContext. Without this, it is possib