This revision was automatically updated to reflect the committed changes.
Closed by commit rL261917: [analyzer] Make ObjCDeallocChecker path sensitive.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17511?vs=48995&id=49097#toc
Repository:
rL LLVM
http://reviews.l
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in th
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:184
@@ -144,21 +183,3 @@
- // Determine if the class subclasses NSObject.
- IdentifierInfo* NSObjectII = &Ctx.Idents.get("NSObject");
- IdentifierInfo* SenTestCaseII = &Ctx.Idents.ge
dcoughlin updated this revision to Diff 48995.
dcoughlin marked 8 inline comments as done.
dcoughlin added a comment.
This update addresses Anna's review comments. The big change is that the
program state now maps instance symbols to sets of initial ivar symbols that
must be released. (Rather th
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:89
@@ -109,7 +88,3 @@
-static bool synthesizedPropertyRequiresRelease(const ObjCPropertyDecl *PD) {
- // A synthesized property must be released if and only if the kind of setter
- //
dcoughlin added a subscriber: cfe-commits.
dcoughlin updated this revision to Diff 48750.
dcoughlin added a comment.
Provide diff with context. Apologies for leaving that out.
http://reviews.llvm.org/D17511
Files:
lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
test/Analysis/DeallocMissing
