LegalizeAdulthood abandoned this revision.
LegalizeAdulthood added a comment.
Herald added a subscriber: xazax.hun.
Herald added a reviewer: serge-sans-paille.
Review process takes too long to make forward progress; abandoning.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D17482/new/
ht
alexfh added a comment.
Let's try to turn this to a productive lane. I'm not against adding this
functionality, if it's actually useful, but as is the patch doesn't meet the
bar. Right now, there are a few action items.
First, could you split the refactorings and send me as a separate patch? Th
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D17482#390237, @alexfh wrote:
> My main concern is that this change makes the already complicated and
> unobvious testing mechanism [...]
The complexity and obtuseness of the existing testing mechanism is unrelated to
this changese
LegalizeAdulthood added a comment.
As it stands currently, you can't commit a header with `CHECK-MESSAGES` and
`CHECK-FIXES` lines and have them verified.
That's the whole point of this changeset.
Currently you have to do something very hacky in order to verify changes made
to headers.
http:
alexfh added a comment.
In http://reviews.llvm.org/D17482#387457, @LegalizeAdulthood wrote:
> I'm sorry to be such a nag and I know you're busy, but
>
> This changeset has been held up for a month and a half. (6 weeks since
> originally posted in http://reviews.llvm.org/D16953)
>
> The chang
LegalizeAdulthood added a comment.
I'm sorry to be such a nag and I know you're busy, but
This changeset has been held up for a month and a half. (6 weeks since
originally posted in http://reviews.llvm.org/D16953)
The change isn't that complicated and there haven't really been any comments
LegalizeAdulthood added a comment.
Squeak
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D17482#372677, @alexfh wrote:
> Sorry for leaving this without attention for a while.
>
> I'm somewhat concerned about this change. It's adding a certain level of
> complexity, but doesn't cover some less trivial cases like handling o
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D17482#372677, @alexfh wrote:
> Can you [...] say how many times this feature is going to be used, if it gets
> added to the testing script?
Since you can't verify changes against headers right now, noone has bothered to
add test c
LegalizeAdulthood added a comment.
test/clang-tidy/misc-unused-parameters.cpp currently does a hack to verify
headers by committing the manually fixed header and diffing it:
// RUN: echo "static void staticFunctionHeader(int i) {}" > %T/header.h
// RUN: echo "static void staticFunctionHeader
alexfh added a comment.
Sorry for leaving this without attention for a while.
I'm somewhat concerned about this change. It's adding a certain level of
complexity, but doesn't cover some less trivial cases like handling of multiple
headers. Can you take a look at existing tests and say how many
LegalizeAdulthood added a comment.
Another week without reviews...
These changes were already split from a previous changeset without being
reviewed properly.
Squeak squeak squeak.
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-c
LegalizeAdulthood added a comment.
Squeak
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
This changeset improves check_clang_tidy.py to allow chnages made by a check to
a header to be verified.
A new argument `--header-filter` allows the test file t
14 matches
Mail list logo
