This revision was automatically updated to reflect the committed changes.
Closed by commit rL263422: [Driver] Enable --rtlib option for MSVC target
(authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D17453?vs=50260&id=50579#toc
Repository:
rL LLVM
http://reviews.llvm.o
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Driver/Tools.cpp:8948
@@ -8947,5 +8947,3 @@
break;
- case ToolChain::RLT_Libgcc:
-AddLibgcc(TC.getTriple(), D, CmdArgs, Args);
-break;
- }
+c
roman.shirokiy updated this revision to Diff 50260.
roman.shirokiy added a comment.
Updated diff with the test for "nostdlib" + "rtlib" case.
http://reviews.llvm.org/D17453
Files:
lib/Driver/Tools.cpp
test/Driver/msvc-compiler-rt.c
test/Driver/nostdlib.c
Index: lib/Driver/Tools.cpp
=
roman.shirokiy added a comment.
Hello!
Thanks for the feedback!
MSVC got its own runtime lib, so the function "AddRunTimeLibs" is not used
anywhere in "visualstudio::Linker::Constructjob" i.e. "--rtlib" option is
currently unused in MSVC environment (there is always a warning: argument
unused
rengolin added a comment.
Hi,
The error is very sensible, but I'm not sure why you're adding compiler-rt in
the second change. Why is that necessary, and where are the tests for it.
Thanks!
--renato
http://reviews.llvm.org/D17453
___
cfe-commits
roman.shirokiy added a comment.
For now every native Windows installation of Clang contains small compiler-rt
builtins lib (http://reviews.llvm.org/rL261432: [CMake] Add partial support for
MSVC in compiler-rt builtins), but there is no specific interface to make use
of this lib on Windows. Thi
roman.shirokiy created this revision.
roman.shirokiy added reviewers: rnk, majnemer, beanz, pcc.
roman.shirokiy added a subscriber: cfe-commits.
This enables "--rtlib compiler-rt" option under MSVC environment.
Related compiler-rt patch:
http://reviews.llvm.org/D17452
http://reviews.llvm
