[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-15 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC354162: [MSVC] Recognize `static_assert` keyword in C and C++98 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D17444?vs=186741&id=187061#toc Repository: rC Clang

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 ___ cfe-commits mailing list cfe-comm

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-13 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Awesome, thanks. Comment at: clang/test/Lexer/keywords_test.cpp:57 +#else +// MS compiler recognizes static_assert in all modes. So should we. +IS_KEYWORD(static_assert); ---

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D17444#1397179 , @STL_MSFT wrote: > @rnk I've forwarded this to the compiler front-end and Universal CRT teams. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ htt

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk commandeered this revision. rnk edited reviewers, added: andreybokhanko; removed: rnk. rnk added a comment. This revision now requires review to proceed. Comandeering and updating description... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1744

[PATCH] D17444: [MSVC] Recognize "static_assert" keyword in C mode

2019-02-13 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. @rnk I've forwarded this to the compiler front-end and Universal CRT teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17444/new/ https://reviews.llvm.org/D17444 ___ cfe-co