Re: [PATCH] D17437: [OpenCL] Add Sema checks for image and pipe

2016-02-19 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5714 @@ +5713,3 @@ + // OpenCL v2.0 s6.9.b + // An image type can only be used as a type of a function argument. + if (getLangOpts().OpenCL && R->isImageType()) { Move to the line above, separat

Re: [PATCH] D17437: [OpenCL] Add Sema checks for image and pipe

2016-02-19 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/SemaOpenCL/invalid-pipes-cl2.0.cl:9 @@ -8,1 +8,3 @@ } +void test4() { + pipe int p; // expected-error {{pipe can only be used as a function parameter}} Do we have a test for diagnosing pipe type for OCL < 2.0 ? h