Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

2016-02-18 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261293: [analyzer] Add checker callback for beginning of function. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D17418?vs=48406&id=48438#toc Repository: rL LLVM http://r

Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

2016-02-18 Thread Devin Coughlin via cfe-commits
dcoughlin marked an inline comment as done. dcoughlin added a comment. http://reviews.llvm.org/D17418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

2016-02-18 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM with a request for a tiny other improvement in the documentation. Thanks! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h:111 @@ -103,3 +110

[PATCH] D17418: [analyzer] Add checker callback for beginning of function.

2016-02-18 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added a reviewer: zaks.anna. dcoughlin added a subscriber: cfe-commits. Add a checker callback that is called when the analyzer starts analyzing a function either at the top level or when inlined. This will be used by a follow-on patch making the DeallocC