steven_wu added a comment.
Thanks for reviewing the patch. There is a problem in the test case (it only
works on darwin). It is fixed in r262286.
Comment at: lib/Driver/Driver.cpp:1761
@@ -1747,1 +1760,3 @@
+const ActionList *BackendInputs =
+ (EmbedBitcode ? Inputs :
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262282: Introduce -fembed-bitcode driver option (authored by
steven_wu).
Changed prior to commit:
http://reviews.llvm.org/D17390?vs=49431&id=49437#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks, that's much clearer :-)
http://reviews.llvm.org/D17390
___
cfe-commits mailing list
cfe-commits@lists.ll
steven_wu updated this revision to Diff 49431.
steven_wu added a comment.
Make selectToolForJob logic better and less disruptive for -fembed-bitcode.
When -fembed-bitcode is used, the same old logic is used to decide if
CompileJob and BackendJob can be combined with an extra requirement for
-femb
thakis added a subscriber: thakis.
thakis added a comment.
I don't understand the changes to Driver.cpp lines 1760 and down. The rest
looks good to me.
Comment at: lib/Driver/Driver.cpp:1761
@@ -1747,1 +1760,3 @@
+const ActionList *BackendInputs =
+ (EmbedBitcode ? Inp
steven_wu created this revision.
steven_wu added a subscriber: cfe-commits.
This is the clang driver part of the change to embedded bitcode. This
includes:
1. -fembed-bitcode option which breaks down the compilation into two
stages. The first stage emits optimized bitcode and the second stage
comp
