This revision was automatically updated to reflect the committed changes.
Closed by commit rL263434: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB
(authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D17286?vs=49459&id=50592#toc
Repository:
rL LLVM
http://reviews.
emaste added a comment.
Seems fine to me
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#372290, @dim wrote:
> If nobody objects, I will commit this.
I can do so myself but would would like to hear from @joerg first
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
dim accepted this revision.
dim added a reviewer: dim.
dim added a comment.
This revision is now accepted and ready to land.
If nobody objects, I will commit this.
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Hahnfeld added a comment.
More comments on this?
Thanks, Jonas
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld updated the summary for this revision.
Hahnfeld updated this revision to Diff 49459.
Hahnfeld added a comment.
Rename option to `-stdlib=platform`
http://reviews.llvm.org/D17286
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/freebs
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#364544, @joerg wrote:
> I was thinking about something like `-stdlib=platform` to reflect that it is
> the target choice.
Ah yes, that was the term I was missing, `architecture` wasn't actually correct
http://reviews.llvm.org/D17286
joerg added a comment.
I was thinking about something like `-stdlib=platform` to reflect that it is
the target choice.
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Hahnfeld added a comment.
In http://reviews.llvm.org/D17286#364353, @joerg wrote:
> I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is
> not. Otherwise, it should be fine.
Hmm, had this feeling as well... What about `-stdlib=test` as I only plan to
use this for the tes
joerg added a comment.
I dislike the value `default`, since with `CLANG_DEFAULT_CXX_STDLIB` it is not.
Otherwise, it should be fine.
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
dim added subscribers: joerg, dim.
dim added a comment.
LGTM, at least. @emaste, @joerg, OK with you too?
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Hahnfeld added a comment.
Gentle ping
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld created this revision.
Hahnfeld added reviewers: rsmith, t.p.northover.
Hahnfeld added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Also introduce `-stdlib=default` to override the configured value and use it to
make the tests always pass.
http://reviews.llvm.org/D17286
13 matches
Mail list logo
