zaks.anna added a comment.
Once tested, this can land.
http://reviews.llvm.org/D17253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added inline comments.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/SATestBuild.py:521
@@ -502,3 +520,3 @@
SummaryLog.write("See the first %d below.\n"
- % (NumOfFailuresInSummary,))
+
zaks.anna added a comment.
Please, test these changes.
Thanks!
Anna.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
import plistlib
-import CmpRuns
+import CmpRuns # ?
ariccio wrote:
> This file imports itself?
>
> I wa
ariccio added a comment.
I've added a few comments where I think the changes are not quite clear.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:159
@@ -147,3 +158,3 @@
if 'clang_version' in data:
-if self.clang_version == None:
+
ariccio added inline comments.
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:194
@@ -182,3 +193,3 @@
# Backward compatibility API.
-def loadResults(path, opts, root = "", deleteEmpty=True):
+def loadResults(path, opts, root="", deleteEmpty=True):
return load
ariccio added a comment.
In http://reviews.llvm.org/D17253#353000, @zaks.anna wrote:
> Not sure how you got these changes, but some of them seem wrong and some seem
> inconsistently applied.
>
> Has this been tested?
Not yet, I was toying with running the first SARD test under it, and read
th
ariccio added a comment.
Whoops, forgot to submit my earlier comments. Responding to comments right
now...
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
import plistlib
-import CmpRuns
+import CmpRuns # ?
This file impo
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
Not sure how you got these changes, but some of them seem wrong and some seem
inconsistently applied.
Has this been tested?
Comment at: C:/LLVM/llvm/tools/cl
