Re: [PATCH] D17206: Fix AST printing of ascii char literals above 127.

2016-02-12 Thread Steven Watanabe via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260795: Fix the ASTPrinter output for ascii char literals >127. (authored by steven_watanabe). Changed prior to commit: http://reviews.llvm.org/D17206?vs=47822&id=47887#toc Repository: rL LLVM http:

Re: [PATCH] D17206: Fix AST printing of ascii char literals above 127.

2016-02-12 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/AST/StmtPrinter.cpp:1253-1256 @@ -1252,2 +1252,6 @@ default: +// A character literal might be sign-extended, which +// would result in an inval

[PATCH] D17206: Fix AST printing of ascii char literals above 127.

2016-02-12 Thread Steven Watanabe via cfe-commits
steven_watanabe created this revision. steven_watanabe added a reviewer: rsmith. steven_watanabe added a subscriber: cfe-commits. Currently literals like '\xff' may be sign extended, resulting in output like '\U', which is not valid. http://reviews.llvm.org/D17206 Files: lib/AST/StmtP