Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

2016-03-30 Thread Jonas Paulsson via cfe-commits
jonpa added a comment. Tests updated per instructions, and commited as r264873. http://reviews.llvm.org/D17142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

2016-03-30 Thread Ulrich Weigand via cfe-commits
uweigand added a comment. I don't think we actually need the builtins-systemz-z13.c test, it only duplicates tests already done by builtins-systemz.c and builtins-systemz-vector.c. (Note that those tests implicitly verify that there is no compiler error by checking the compiler exit code.) Al

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

2016-03-30 Thread Jonas Paulsson via cfe-commits
jonpa updated this revision to Diff 52026. jonpa added a comment. Tests updated to run with -verify and now work as expected. http://reviews.llvm.org/D17142 Files: include/clang/Basic/BuiltinsSystemZ.def lib/Basic/Targets.cpp test/CodeGen/builtins-systemz-generic0.c test/CodeGen/builtin

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

2016-03-29 Thread Ulrich Weigand via cfe-commits
uweigand added a comment. > This patch has been reworked, and aims to specify which features systemz > builtins require. The way of doing this has been taken from the X86 Target > (with a '#define TARGET_BUILTIN') > > If a builtin is used by the programmer for a target that does not include a

Re: [PATCH] D17142: SystemZ: Check required features when handling builtins

2016-03-29 Thread Jonas Paulsson via cfe-commits
jonpa retitled this revision from "SystemZ: Check that argument -fzvector is only given for -z13" to "SystemZ: Check required features when handling builtins". jonpa updated the summary for this revision. jonpa updated this revision to Diff 51910. jonpa added a comment. This patch has been rewor