This revision was automatically updated to reflect the committed changes.
Closed by commit rL260388: [MS ABI] Never reference dllimport'd vtables
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17061?vs=47407&id=47473#toc
Repository:
rL LLVM
http://reviews.llvm.org
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm if you clarify that bit
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1676
@@ -1675,2 +1675,3 @@
- llvm::GlobalValue::LinkageTypes VFTableLinkage = CGM.getVTableLinkage(RD);
+
majnemer created this revision.
majnemer added reviewers: rnk, hans, thakis, rsmith.
majnemer added a subscriber: cfe-commits.
Referencing a dllimported vtable is impossible in a constexpr
constructor. It would be friendlier to C++ programmers if we
synthesized a copy of the vftable which referen
