This revision was automatically updated to reflect the committed changes.
Closed by commit rL262752: PR5941 - improve diagnostic for * vs & confusion
when choosing overload… (authored by dblaikie).
Changed prior to commit:
http://reviews.llvm.org/D16949?vs=49577&id=49856#toc
Repository:
rL L
ryee88 added a comment.
Thanks! I don’t have commit permissions; can you submit for me?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks great - thanks!
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm
ryee88 updated this revision to Diff 49577.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/overload-call.cpp
===
--
ryee88 added a comment.
Yeah you’re right about this one being the original variant. I missed it when I
was reading through the tests in this file.
I’ve reworked it to reflect the new variants.
http://reviews.llvm.org/D16949
___
cfe-commits mailin
dblaikie added a comment.
Are there not any existing cases that test this diagnostic?
Could you just update some existing cases to cover this? (it looks like, in the
same file, the test case added for PR 6117 could be expanded to test this as
well, perhaps?) It looks like that's the original te
ryee88 updated this revision to Diff 49280.
ryee88 added a comment.
Moved test to a file that checks for similar diagnostics.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/over
On Tue, Feb 16, 2016 at 10:45 PM, David Blaikie wrote:
>
>
> On Tue, Feb 16, 2016 at 10:01 PM, Ryan Yee via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> ryee88 updated this revision to Diff 48149.
>> ryee88 added a comment.
>>
>> Keeping the number of test files to a minimum makes sens
ryee88 added a comment.
any comments?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Feb 16, 2016 at 10:01 PM, Ryan Yee via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ryee88 updated this revision to Diff 48149.
> ryee88 added a comment.
>
> Keeping the number of test files to a minimum makes sense.
>
> Couldn't find an existing test for this diagnostic.
That woul
ryee88 updated this revision to Diff 48149.
ryee88 added a comment.
Keeping the number of test files to a minimum makes sense.
Couldn't find an existing test for this diagnostic. I did find a
cxx-reference.cpp that tests reference diagnostics so this seems like a
reasonable location for this ne
Since this is just a wording change, presumably the diagnostic is already
tested in an existing file - perhaps you could exetendi that test to cover
this functionality (we try not to add new test files too much - better to
test functionality once/in one place as much as possible (both for ease of
r
ryee88 updated this revision to Diff 47925.
ryee88 added a comment.
Sorry-- re-uploading the diff. Didn't notice I dropped the code changes.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/Parser/overloaded-pointer-vs-referen
ryee88 updated this revision to Diff 47924.
ryee88 added a comment.
Added unit test as per review comments.
http://reviews.llvm.org/D16949
Files:
test/Parser/overloaded-pointer-vs-reference-hint.cpp
Index: test/Parser/overloaded-pointer-vs-reference-hint.cpp
=
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
Needs test coverage
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 added a comment.
Ping-- can someone look at this review?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 created this revision.
ryee88 added reviewers: doug.gregor, jyasskin, nicholas, rsmith.
ryee88 added a subscriber: cfe-commits.
This is bug 5941: https://llvm.org/bugs/show_bug.cgi?id=5941
I copied the extra suggestions from the complete type case to the incomplete
type case.
http://revi
17 matches
Mail list logo
