EricWF added a comment.
Ping!
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On 2016-Feb-06, at 15:40, Eric Fiselier wrote:
>
>> > +// The "hash_value" function is tested as part of [path.compare]
>> > +// in class.path/path.members/path.compare.pass.cpp
>> > +int main() {}
>>
>> Okay, I get the idea of the one above. I'm guessing this is just how
>> we mark that som
EricWF added a comment.
In http://reviews.llvm.org/D16948#345722, @dexonsmith wrote:
> Light review below, looks like great work.
>
> I noticed the tests seem somewhat inconsistent about whether to
> glue `&` to the type or use two spaces (i.e., ` & `). Which one is
> preferred in this codebas
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Light review below, looks like great work.
I noticed the tests seem somewhat inconsistent about whether to
glue `&` to the type or use two spaces (i.e., ` & `). Which one is
preferred in this codebase? Or is it laissez-faire
Light review below, looks like great work.
I noticed the tests seem somewhat inconsistent about whether to
glue `&` to the type or use two spaces (i.e., ` & `). Which one is
preferred in this codebase? Or is it laissez-faire?
The rest of my comments are inline.
> On 2016-Feb-06, at 12:48, Eric
