This revision was automatically updated to reflect the committed changes.
Closed by commit rL261151: [CodeGen] Fix an assert in
CodeGenFunction::EmitFunctionEpilog (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D16914?vs=47062&id=48232#toc
Repository:
rL LLVM
http:
manmanren added a comment.
LGTM otherwise.
Cheers,
Manman
Comment at: lib/CodeGen/CGCall.cpp:2468
@@ +2467,3 @@
+ QualType RT;
+
+ if (auto *FD = dyn_cast(CurCodeDecl))
Maybe add comments here on the if else block?
http://reviews.llvm.org/D16914
ahatanak added a reviewer: manmanren.
ahatanak added a comment.
ping
http://reviews.llvm.org/D16914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a reviewer: rjmccall.
ahatanak updated this revision to Diff 47062.
ahatanak added a comment.
Enclose the code with "#ifndef NDEBUG".
http://reviews.llvm.org/D16914
Files:
lib/CodeGen/CGCall.cpp
test/CodeGenObjCXX/auto-release-result-assert.mm
Index: test/CodeGenObjCXX/auto-
I agree with you, that was actually what John suggested too.
I'll update the patch shortly.
On Fri, Feb 5, 2016 at 3:38 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2016-Feb-04, at 18:54, Akira Hatanaka via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > ahatana
> On 2016-Feb-04, at 18:54, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak created this revision.
> ahatanak added a subscriber: cfe-commits.
>
> The assert near CGCall.cpp:2465 is triggered because
> QualType::isObjCRetainableType() is called on different types. In
> CodeGenFunction::
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
The assert near CGCall.cpp:2465 is triggered because
QualType::isObjCRetainableType() is called on different types. In
CodeGenFunction::StartFunction, it returns true because it is called on the
typedef marked with __attr
