Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259195: [clang-tidy] Move implicit-cast-in-loop check to upstream. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D16721?vs=46377&id=46381#toc Repository: rL LLVM http://revi

Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

alexfh added inline comments. Comment at: test/clang-tidy/performance_implicit_cast_in_loop.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s performance-implicit-cast-in-loop %t + Also, the name should use dashes, not underscores. I'll fix this as well. Repository

Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. I'll fix and commit the patch. Thank you! Comment at: clang-tidy/performance/ImplicitCastInLoopCheck.cpp:79 @@ +78,3 @@ + // code at the end). + if