Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-02-01 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D16708#340359, @gottesmm wrote: > I think that my response via email did not hit phabriactor. So sorry for the > delay. No worries! > Yes there is a forthcoming patch for CodeGen which will place an attribute on > the relevant functio

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-01-31 Thread Michael Gottesman via cfe-commits
gottesmm added inline comments. Comment at: include/clang/Basic/Attr.td:540 @@ +539,3 @@ + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > Please, no undocumented new attributes. You should modify AttrDocs.

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-01-31 Thread Michael Gottesman via cfe-commits
gottesmm added a comment. I think that my response via email did not hit phabriactor. So sorry for the delay. Yes there is a forthcoming patch for CodeGen which will place an attribute on the relevant functions. The attribute will be queried in the middle end optimizer. The reason why there ha

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-01-31 Thread Michael Gottesman via cfe-commits
> On Jan 29, 2016, at 6:02 AM, Aaron Ballman wrote: > > aaron.ballman added a subscriber: aaron.ballman. > aaron.ballman added a reviewer: aaron.ballman. > aaron.ballman added a comment. > > It's a bit strange to add an attribute that has absolutely no semantic effect > whatsoever. Where is th

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-01-29 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. It's a bit strange to add an attribute that has absolutely no semantic effect whatsoever. Where is this attribute intended to be queried within the compiler? Are there a

Re: [PATCH] D16708: Add a new attribute CFNoRelease.

2016-01-28 Thread Michael Gottesman via cfe-commits
gottesmm updated this revision to Diff 46354. gottesmm added a comment. Added documentation. http://reviews.llvm.org/D16708 Files: include/clang/Basic/Attr.td lib/Sema/SemaDeclAttr.cpp test/SemaObjC/attr-cf_no_release.m Index: test/SemaObjC/attr-cf_no_release.m ==