Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Landed as r259014 and r259015. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 46210. mclow.lists added a comment. Add the tests that Eric suggested. Had to toss in a `decay`. http://reviews.llvm.org/D16605 Files: test/std/experimental/iterator/nothing_to_do.pass.cpp test/std/experimental/iterator/ostream.joiner/ostream.joine

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Eric Fiselier via cfe-commits
EricWF added a comment. One last thing. The spec implicitly defines the copy/move/assignment operators for "ostream_joiner" by making "_Delim" an exposition only member. Essentially "ostream_joiner" should only copy/moveable if "_Delim" is. I think we should add tests that ensure we actually fo

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists marked 4 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 46203. mclow.lists added a comment. Addressed Eric's comments. (at least some of them) http://reviews.llvm.org/D16605 Files: test/std/experimental/iterator/nothing_to_do.pass.cpp test/std/experimental/iterator/ostream.joiner/ostream.joiner.cons/ost

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/experimental/iterator:62 @@ +61,3 @@ + +_LIBCPP_BEGIN_NAMESPACE_LFTS + EricWF wrote: > Wrong namespace. This gives `std::experimental::fundamentals_v2`. This brings > up the bigger question of how we want to

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: include/experimental/iterator:85 @@ +84,3 @@ +template +ostream_joiner& operator=(const _Tp& __v) +{ EricWF wrote: > People are going to try and use this as an assignment operator. We either > need to static a

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-27 Thread Eric Fiselier via cfe-commits
EricWF added a comment. - Please add the header to `test/libcxx/double_include.sh.cpp` - Please add a `_LIBCPP_VERSION` test in `test/libcxx/experimental/iterator` - The `ostream_joiner` type and it's members should be given visibility attributes. Comment at: include/experiment

[PATCH] D16605: Implement `std::experimental::ostream_joiner`

2016-01-26 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. This is part of the Library Fundamentals 2 TS http://reviews.llvm.org/D16605 Files: include/experimental/iterator test/std/experimental/iterator/nothing_to_do.