Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-05 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. Instead of checking by division by zero, I've used _StaticAssert. Functionally bo change, but more understandable. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-05 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. No, just make test case more 'standard'. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-05 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. I am missing to understand the intention of this change. Are you trying to improve the testing for OpenCL? http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-03 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. Please review and accept. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-03 Thread Igor Chesnokov via cfe-commits
ichesnokov removed rL LLVM as the repository for this revision. ichesnokov updated this revision to Diff 46877. ichesnokov added a comment. Patch improvements http://reviews.llvm.org/D16574 Files: test/SemaOpenCL/char-must-be-signed.cl Index: test/SemaOpenCL/char-must-be-signed.cl ==

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-02-03 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. Please review and approve. Repository: rL LLVM http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-01-31 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. Please review and commit. Repository: rL LLVM http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

2016-01-30 Thread Igor Chesnokov via cfe-commits
ichesnokov added a comment. BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685 Repository: rL LLVM http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c