Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258817: [OpenMP] Parsing + sema for defaultmap clause. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16527?vs=45856&id=46000#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-25 Thread Arpith Jacob via cfe-commits
arpith-jacob marked 5 inline comments as done. arpith-jacob added a comment. Patch fixed. http://reviews.llvm.org/D16527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-25 Thread Arpith Jacob via cfe-commits
arpith-jacob updated this revision to Diff 45856. arpith-jacob added a comment. Addressed fixes by Alexey Bataev. Thanks. http://reviews.llvm.org/D16527 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/OpenMPKinds.def include/clang/Bas

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-24 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:3408-3409 @@ +3407,4 @@ +Kind(Kind), KindLoc(KLoc) { +Modifier = M; +ModifierLoc = MLoc; + } Why these are not initialized in initializer list, along with Kind, KindLoc e

[PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

2016-01-24 Thread Arpith Jacob via cfe-commits
arpith-jacob created this revision. arpith-jacob added reviewers: hfinkel, kkwli0, sfantao, carlo.bertolli, ABataev. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. This patch adds parsing + sema for the defaultmap clause associated with the target directive (among others). h