Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

2016-01-22 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. r258503, thanks! (with the extra test) http://reviews.llvm.org/D16413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

2016-01-22 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. I'd probably add a test to unittests/Tooling/RecursiveASTVisitorTest.cpp. http://reviews.llvm.org/D16413 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

2016-01-21 Thread Nico Weber via cfe-commits
thakis updated this revision to Diff 45551. thakis added a comment. fix test name http://reviews.llvm.org/D16413 Files: include/clang/AST/RecursiveASTVisitor.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: include/clang/AST/RecursiveASTVisitor.h =

[PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

2016-01-21 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added reviewers: rsmith, klimek. thakis added a subscriber: cfe-commits. Herald added a subscriber: klimek. An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer. RecursiveASTVisitor used to not visit them, so that they didn't show up in