This revision was automatically updated to reflect the committed changes.
Closed by commit rL258642: [CUDA] Make printf work. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16372?vs=45456&id=45810#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16372
Files:
cfe/t
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
-eric
http://reviews.llvm.org/D16372
___
cfe-commits mailing list
cfe-commits@l
jlebar updated this revision to Diff 45456.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDABuiltin.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunctio
jlebar added inline comments.
Comment at: test/CodeGenCUDA/printf.cu:12
@@ +11,3 @@
+// Check a simple call to printf end-to-end.
+__device__ int CheckSimple() {
+ // CHECK: [[FMT:%[0-9]+]] = load{{.*}}%fmt
tra wrote:
> You may want to add a test case for printf(
tra added inline comments.
Comment at: lib/CodeGen/CGCUDACall.cpp:1
@@ +1,2 @@
+//===- CGCUDACall.cpp - Codegen for special CUDA calls
===//
+//
We'll need to handle other builtins soon. Perhaps we can keep them in this file
and rename it CGC
jlebar updated this revision to Diff 45446.
jlebar added a comment.
Remove {} around an if statement.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDACall.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunction.h
lib/Headers/__clang_cuda_runtime_wr
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
The code in CGCUDACall is largely based on a patch written by Eli
Bendersky:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20140324/210218.html
That patch implemented an L
