Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-26 Thread Yunzhong Gao via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258850: Do not define GXX_RTTI macro for C. (authored by ygao). Changed prior to commit: http://reviews.llvm.org/D16365?vs=45416&id=46031#toc Repository: rL LLVM http://reviews.llvm.org/D16365 File

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-26 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. LGTM, assuming this is the same behaviour as GCC. http://reviews.llvm.org/D16365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-26 Thread Richard Smith via cfe-commits
LGTM, assuming this is the same behaviour as GCC. On 26 Jan 2016 1:59 a.m., "Yunzhong Gao" wrote: > ygao added a comment. > > A gentle ping. > > > http://reviews.llvm.org/D16365 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-25 Thread Yunzhong Gao via cfe-commits
ygao added a comment. A gentle ping. http://reviews.llvm.org/D16365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16365: Do not define GXX_RTTI macro for C

2016-01-20 Thread Yunzhong Gao via cfe-commits
ygao created this revision. ygao added a reviewer: rsmith. ygao added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. Hi, I was looking at the list of pre-defined macros by the new LLVM release and noticed that the __GXX_RTTI macro is being defined for both C and C++, and I wo