Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268075: Improve test coverage of -Wdouble-promotion (authored by rlougher). Changed prior to commit: http://reviews.llvm.org/D16298?vs=45195&id=55625#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-29 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. No problem. Thanks for the code review. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-28 Thread George Burgess IV via cfe-commits
george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv accepted this revision. george.burgess.iv added a reviewer: george.burgess.iv. george.burgess.iv added a comment. This revision is now accepted and ready to land. Hey -- I'm really sorry about the latency on this; I recentl

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-28 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-03-03 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. Please can somebody review this? Thanks! http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-02-23 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. Just test changes - OK to commit? http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-01-27 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-01-18 Thread Robert Lougher via cfe-commits
rob.lougher created this revision. rob.lougher added a reviewer: gbiv. rob.lougher added a subscriber: cfe-commits. The -Wdouble-promotion warning was added to clang in r251588 (fixing PR15109). The added test, however, only covered a subset of the cases where implicit conversion can occur (ass