andreybokhanko added a comment.
Rafael, thanks for the review!
In http://reviews.llvm.org/D16295#329929, @rafael wrote:
> I am pretty sure the cases in init.c are wrong as the assembly itself
> doesn't use a '_'.
>
> Having said that, it is probably a good thing to do this in two steps.
> So t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258504: Change of UserLabelPrefix default value from "_" to
"" (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D16295?vs=45177&id=45687#toc
Repository:
rL LLVM
http://review
I am pretty sure the cases in init.c are wrong as the assembly itself
doesn't use a '_'.
Having said that, it is probably a good thing to do this in two steps.
So this patch LGTM on the condition that you also open a bug to audit
the cases where we define __USER_LABEL_PREFIX__ to _ in init.c and C
andreybokhanko added a comment.
@rafael, all these changes are driven by tests.
It seems you mean OS targeting, which is handled in other TargetInfo classes
(LinuxTargetInfo in Linux case).
Comment at: lib/Basic/Targets.cpp:801
@@ -818,2 +800,3 @@
LongDoubleFormat = &llvm
rafael added a comment.
Thanks for working on this, but many of the changes setting the prefix to "_"
look wrong.
Comment at: lib/Basic/Targets.cpp:801
@@ -818,2 +800,3 @@
LongDoubleFormat = &llvm::APFloat::PPCDoubleDouble;
+UserLabelPrefix = "_";
}
andreybokhanko created this revision.
andreybokhanko added reviewers: rafael, rjmccall.
andreybokhanko added subscribers: cfe-commits, rafael.
@rafael proposed (http://reviews.llvm.org/D16138#325739) to change
UserLablePrefix's default from "_" to "", as latter value happens much more
often. Thi
