This revision was automatically updated to reflect the committed changes.
Closed by commit rL260851: As reported in
https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD, (authored by dim).
Changed prior to commit:
http://reviews.llvm.org/D16264?vs=47913&id=47930#toc
Repository:
rL LLVM
h
dim updated this revision to Diff 47913.
dim added a comment.
Add checks for -lm and -lm_p, when profiling is on.
http://reviews.llvm.org/D16264
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/freebsd.cpp
Index: test/Driver/freebsd.cpp
===
compnerd added a comment.
I think it would be better if we could actually create a helper to get the
profiling library name for a specific library, and use that in both locations.
Do we have a test for the math case at the very least?
http://reviews.llvm.org/D16264
_
dim added a comment.
In http://reviews.llvm.org/D16264#340131, @compnerd wrote:
> `-p` or `-pg` also effects the math library. Please adjust the tests and the
> driver to reflect that.
This is already handled in `lib/Driver/Tools.cpp`, in
`freebsd::Linker::ConstructJob()`:
if (!Args.hasAr
compnerd added a comment.
`-p` or `-pg` also effects the math library. Please adjust the tests and the
driver to reflect that.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
dim added a comment.
Ping.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dws added a comment.
I will try this out on a system running FreeBSD HEAD (as of r294306) and see
how it does.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
dim created this revision.
dim added reviewers: compnerd, davide, dws, emaste.
dim added subscribers: rpokala, cfe-commits.
Herald added a subscriber: emaste.
As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,
C++ programs compiled for profiling (using `-pg`) should be linked
