Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r258107.
https://reviews.llvm.org/D16262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
jpetrie added a comment.
In http://reviews.llvm.org/D16262#329328, @mclow.lists wrote:
> This looks good to me. A quick search for `\\` in regex didn't find any
> other obvious instances of this anti-pattern. For the record, the bug is
> https://llvm.org/bugs/show_bug.cgi?id=26175
>
> Can you
jpetrie created this revision.
jpetrie added a reviewer: mclow.lists.
jpetrie added a subscriber: cfe-commits.
std::regex should throw std::regex_error if constructed with a pattern ending
in a trailing backslash, since a trailing backlash is not a valid escape
sequence.
http://reviews.llvm.org
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me. A quick search for `\\` in regex didn't find any other
obvious instances of this anti-pattern. For the record, the bug is
https://llvm.org/bugs/show_bug.cgi?
