Re: [PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257983: Respect bound archs, even when they don't alter the toolchain. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16250?vs=45061&id=45064#toc Repository: rL LLVM http://

Re: [PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Justin Lebar via cfe-commits
jlebar added a comment. In http://reviews.llvm.org/D16250#328552, @tra wrote: > Looks OK to me. > Perhaps BoundArch w/o toolchain is sufficient for the key as toolchain would > be derived from it. Yeah, it might work, I wasn't convinced it was sound. The bound TC is derived from the origin

Re: [PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Artem Belevich via cfe-commits
tra added a comment. Looks OK to me. Perhaps BoundArch w/o toolchain is sufficient for the key as toolchain would be derived from it. http://reviews.llvm.org/D16250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Eric Christopher via cfe-commits
Ultimately they probably shouldn't map to the same toolchain and we can use that as a key. Looks OK for now though. On Fri, Jan 15, 2016, 5:48 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: cfe-commits, beanz, echristo. > Herald

Re: [PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Ultimately they probably shouldn't map to the same toolchain and we can use that as a key. Looks OK for now though. http://reviews.llvm.org/D16250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D16250: Respect bound archs, even when they don't alter the toolchain.

2016-01-15 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, beanz, echristo. Herald added a subscriber: aemerson. It's possible to BindArch without changing the toolchain at all. For example, armv7 and armv7s have exactly the same triple. Therefore the code