Re: [PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

2016-01-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258039: [analyzer] Fix an off-by-one in evalIntegralCast() (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D16178?vs=44842&id=45159#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

2016-01-14 Thread pierre gousseau via cfe-commits
pgousseau accepted this revision. pgousseau added a comment. This revision is now accepted and ready to land. LGTM! Thanks Artom for finding the bug and new test case, sorry for missing those in my patch! Removing "!IsNotTruncated" is definitely worth trying. Please commit if code owners are happ

[PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

2016-01-14 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: pgousseau, zaks.anna, dcoughlin, xazax.hun. NoQ added a subscriber: cfe-commits. Sorry for being a bit slow, i should have had a look at the review earlier; i noticed some stuff after the recent patch by Pierre Gousseau was committed. 1. There's an