This revision was automatically updated to reflect the committed changes.
Closed by commit rL257809: [CUDA] Invoke ptxas and fatbinary during
compilation. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16082?vs=44586&id=44921#toc
Repository:
rL LLVM
http://reviews.l
echristo accepted this revision.
echristo added a comment.
This is terrible, but the only other option is fixing bind arch and inverting
the graph which is a major rewrite to the driver.
So, LGTM.
-eric
http://reviews.llvm.org/D16082
___
cfe-comm
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 44586.
jlebar added a comment.
Add test checking that sm_XX gets translated to compute_YY correctly.
http://reviews.llvm.org/D16082
Files:
include/clang/Driver/Action.h
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
include/clang/Dr
jlebar added a comment.
In http://reviews.llvm.org/D16082#324138, @tra wrote:
> Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as.
> They tend to throw wrenches into pipeline construction.
Thanks. All of them worked except -fintegrated-as, which was causing us not to
jlebar updated this revision to Diff 44584.
jlebar marked 8 inline comments as done.
jlebar added a comment.
Address tra, echristo's review comments.
http://reviews.llvm.org/D16082
Files:
include/clang/Driver/Action.h
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
incl
echristo added a comment.
One question inline, one nit, and one more question here: You've got a couple
of checks inline for null names/architectures, where do you expect those to
come from and can you test for them? Or, another question, is if they're
multiple architectures shouldn't we be abl
tra added a comment.
Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as.
They tend to throw wrenches into pipeline construction.
Comment at: lib/Driver/Driver.cpp:1380
@@ +1379,3 @@
+ C.MakeAction(DeviceActions, types::TY_CUDA_FATBIN),
+ /* Gpu
jlebar created this revision.
jlebar added reviewers: tra, echristo.
jlebar added subscribers: jhen, cfe-commits.
Previously we compiled CUDA device code to PTX assembly and embedded
that asm as text in our host binary. Now we compile to PTX assembly and
then invoke ptxas to assemble the PTX into
