mjacob abandoned this revision.
mjacob added a comment.
I experimented with another approach in the meantime.
http://reviews.llvm.org/D15998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
sanjoy resigned from this revision.
sanjoy removed a reviewer: sanjoy.
sanjoy added a comment.
Resigning for now to make my "Revisions Waiting on You" queue less noisy.
Please don't hesitate to add me back if this or a variant of this change
becomes active.
http://reviews.llvm.org/D15998
_
aaron.ballman added a comment.
In http://reviews.llvm.org/D15998#324821, @mjacob wrote:
> In http://reviews.llvm.org/D15998#324757, @aaron.ballman wrote:
>
> > Can you point me to some documentation on what the semantics of this
> > attribute are? For instance, how does it play with other attrib
mjacob added a comment.
In http://reviews.llvm.org/D15998#324757, @aaron.ballman wrote:
> Can you point me to some documentation on what the semantics of this
> attribute are? For instance, how does it play with other attributes (like
> naked or dllexport), is there a reason it shouldn't apply
aaron.ballman added a comment.
Can you point me to some documentation on what the semantics of this attribute
are? For instance, how does it play with other attributes (like naked or
dllexport), is there a reason it shouldn't apply to Objective-C methods, etc?
Comment at: incl
mjacob added a comment.
In http://reviews.llvm.org/D15998#324354, @reames wrote:
> Also, before this gets exposed through Clang, we really should
> formalize/document the attribute. In practice, it implies the lack of a
> safepoint poll site inside the called function. Annoyingly, it's not a
majnemer added subscribers: aaron.ballman, majnemer.
majnemer added a comment.
This change looks fine modulo the documentation issue.
Comment at: include/clang/Basic/Attr.td:2177
@@ +2176,3 @@
+ let Subjects = SubjectList<[Function]>;
+ let Documentation = [Undocumented];
+}
-
reames added a comment.
Neither Sanjoy or I are qualified to review a clang patch. You'll need to find
clang reviewers.
Also, before this gets exposed through Clang, we really should
formalize/document the attribute. In practice, it implies the lack of a
safepoint poll site inside the calle
