[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-22 Thread Daniel Thornburgh via Phabricator via cfe-commits
mysterymath added a comment. There should also be tests for this behavior in llvm/test/CodeGen/X86. I wouldn't think it necessary to fully test the calling convention; that should already be well covered; just something in those key test files (e.g., `sse-regcall.ll`) to verify that the `uefi`

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557214. Prabhuk added a comment. Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for Swift and OCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D15

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Daniel Thornburgh via Phabricator via cfe-commits
mysterymath added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:522 // Mingw64 and native Win64 use Win64 CC CCIfSubtarget<"isTargetWin64()", CCDelegateTo>, You'll need to add switching for Win64 here too; this appears to be the conv

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557203. Prabhuk added a comment. Uploading the backend changes correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D159540 Files: llvm/lib/Target/X86/MCTargetDesc/X8

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557199. Prabhuk added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang Driver changes for UEFI X86_64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ htt