[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

2023-11-02 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added a comment. > One such heuristic is to check the nodes in the selection tree for the exact > line match It looks like this heuristic doesn't work well in multiline cases. E.g. int f^unc() { return 0; } will give empty result with this patch applied. Repository: rG L

[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

2023-10-02 Thread Kugan Vivekanandarajah via Phabricator via cfe-commits
kuganv added a comment. ping? Any thoughts. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159497/new/ https://reviews.llvm.org/D159497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

2023-09-11 Thread Kugan Vivekanandarajah via Phabricator via cfe-commits
kuganv created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. kuganv retitled this revision from "[clangd] Check if SelectionTree is complete" to "[RFC][clangd] Check if SelectionTree is complete". kuganv edited the summary of this revision. kuganv added