[PATCH] D159490: Fix warning in MSVC

giulianobelinassi added a comment. In D159490#4643199 , @erichkeane wrote: > Fixed in 6c0b9e357617 > . I > didn't verify ahead of time, but hopefully the bots will yell at ME this ti

[PATCH] D159490: Fix warning in MSVC

fdeazeve added a comment. In D159490#4643199 , @erichkeane wrote: > Fixed in 6c0b9e357617 > . I > didn't verify ahead of time, but hopefully the bots will yell at ME this time > and

[PATCH] D159490: Fix warning in MSVC

erichkeane added a comment. Fixed in 6c0b9e357617 . I didn't verify ahead of time, but hopefully the bots will yell at ME this time and I'll recognize it right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159490: Fix warning in MSVC

erichkeane added a comment. In D159490#4643196 , @giulianobelinassi wrote: > In D159490#4643191 , @fdeazeve > wrote: > >> I think this may have broken builds: >> >> worktrees/src1/clang/lib/AST/DeclPrinter.cpp

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi added a comment. In D159490#4643191 , @fdeazeve wrote: > I think this may have broken builds: > > worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function > definition is not allowed here > static bool mustPrintOnLeftSid

[PATCH] D159490: Fix warning in MSVC

fdeazeve added a comment. I think this may have broken builds: worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function definition is not allowed here static bool mustPrintOnLeftSide(const Attr *A) { Probably missing a `}`? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D159490: Fix warning in MSVC

erichkeane closed this revision. erichkeane added a comment. Forgot to close the phab review automatically, but: 0323938d3c7a1a48b60a7dea8ec7300e98b4a931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D159490: Fix warning in MSVC

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems good enough to me. I'll commit it for you as before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159490/new/ https://revie

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi created this revision. giulianobelinassi added reviewers: aaron.ballman, erichkeane. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there is no `PrintOnLeft` attrib