[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-12 Thread Manos Anagnostakis via Phabricator via cfe-commits
manosanag added a comment. Moved to https://github.com/llvm/llvm-project/pull/66098. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ https://reviews.llvm.org/D159480 ___ cfe-commits mailing lis

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-10 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. We do not usually add front-end clang options for optimizations like this. Users are more likely to use them incorrectly, or just not know that they exist. The usual method would be to make a subtarget tuning feature that controls whether ldp are created, and enable it

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-08 Thread Philipp Tomsich via Phabricator via cfe-commits
philipp.tomsich added a comment. Should we move this to a GitHub PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ https://reviews.llvm.org/D159480 ___ cfe-commits mailing list cfe-co

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-08 Thread Manos Anagnostakis via Phabricator via cfe-commits
manosanag added a comment. Hello Dave, thanks for replying. Yes, this is an optimization. On some AArch64 cores, including Ampere's ampere1 architecture that this is targeted for, load/store pair instructions are faster compared to simple loads/stores only when the alignment of the pair is at

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-07 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Can you give more details about why this is wanted and in which cases it helps with? Is it an optimization, as opposed to working around some correctness issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ ht

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-07 Thread Manos Anagnostakis via Phabricator via cfe-commits
manosanag updated this revision to Diff 556154. manosanag added a comment. Updated Options.td to provide visibility for the options, because it caused a regression for my fortran tests after rebasing to current llvm main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-07 Thread Manos Anagnostakis via Phabricator via cfe-commits
manosanag created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a reviewer: sscalpone. Herald added a project: All. manosanag requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This