This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb70f1f836da9: Haiku: Pick up a few more codegen parametres
from downstream (authored by X512 , committed by
brad).
Repository:
nielx accepted this revision.
nielx added a comment.
This revision is now accepted and ready to land.
Patch looks good to me and in line with previous work that was done on LLVM to
run it on Haiku.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1594
brad updated this revision to Diff 555626.
brad marked an inline comment as not done.
brad added a comment.
Use --target= for all additions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159409/new/
https://reviews.llvm.org/D159409
Files:
clang/
brad updated this revision to Diff 555623.
brad added a comment.
Bump DWARF version to 4.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159409/new/
https://reviews.llvm.org/D159409
Files:
clang/lib/Driver/ToolChains/Haiku.h
clang/test/CodeGen/
brad added a comment.
Comment at: clang/lib/Driver/ToolChains/Haiku.h:39
+
+ unsigned GetDefaultDwarfVersion() const override { return 2; }
+
nielx wrote:
> I propose pushing this to version 4. Haiku's GCC also defaults to version 4
> now.
I was using the ve
nielx added a comment.
Have you been able to test the changes?
Comment at: clang/lib/Driver/ToolChains/Haiku.h:39
+
+ unsigned GetDefaultDwarfVersion() const override { return 2; }
+
I propose pushing this to version 4. Haiku's GCC also defaults to version 4 n
brad updated this revision to Diff 555622.
brad added a comment.
More context
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159409/new/
https://reviews.llvm.org/D159409
Files:
clang/lib/Driver/ToolChains/Haiku.h
clang/test/CodeGen/dwarf-versio
brad updated this revision to Diff 555621.
brad added a comment.
Add a test for the debug handling.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159409/new/
https://reviews.llvm.org/D159409
Files:
clang/lib/Driver/ToolChains/Haiku.h
clang/tes
brad created this revision.
brad added reviewers: nielx, korli.
brad added a project: clang.
Herald added a project: All.
brad requested review of this revision.
Herald added a subscriber: MaskRay.
Pick up a few more codegen parametres from downstream.
DWARF version 2, Math Errno handling, ObjC A